fix(dex): solve token left in dex contract issue #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## build_pancake_dex #8 +/- ##
=====================================================
- Coverage 36.36% 36.17% -0.20%
=====================================================
Files 14 16 +2
Lines 319 329 +10
Branches 33 34 +1
=====================================================
+ Hits 116 119 +3
- Misses 194 200 +6
- Partials 9 10 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
CryptJS13
reviewed
Sep 13, 2023
| import "../../libraries/Errors.sol"; | ||
|
|
||
| abstract contract BasicDex { | ||
| modifier afterSwapCheck(address _sellToken, address _buyToken) { |
There was a problem hiding this comment.
I don't see the modifier being used anywhere. Is that correct?
There was a problem hiding this comment.
Yes, thank you for the catch. I've added them to the actual DEX. I was only testing it in the mockDex.
CryptJS13
approved these changes
Sep 13, 2023
ryanycw
added a commit
that referenced
this pull request
Sep 20, 2023
* chore: change test helper file name * build: implement basicDex with tokenWithdraw feature * test: mock basic dex * fix: add token withdraw to all dexes * chore: adjust input type to calldata * build: add invalid balance error * test: add afterswap test * refactor: add token check modifier to doSwap * chore: consistent between optimizer * fix: solve stack too deep issue * fix: disable optimizer in test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In this pull request we aim to solve the issue that sell token might left in dex contract.
Details
The main changes in this pull request is: